Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:RuntimeManagementConfig #3274

Merged
merged 2 commits into from
Jul 27, 2023
Merged

fix:RuntimeManagementConfig #3274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f4c1c8
Fix RuntimeManagementConfig
ConnorRobertson Jul 27, 2023
eb452f5
run make pr
ConnorRobertson Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion samtranslator/model/lambda_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ class LambdaVersion(Resource):
"CodeSha256": GeneratedProperty(),
"Description": GeneratedProperty(),
"FunctionName": GeneratedProperty(),
"RuntimeManagementConfig": GeneratedProperty(),
}

runtime_attrs = {
Expand Down
2 changes: 0 additions & 2 deletions samtranslator/model/sam_resources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -934,8 +934,6 @@ def _construct_version(
lambda_version = LambdaVersion(logical_id=logical_id, attributes=attributes)
lambda_version.FunctionName = function.get_runtime_attr("name")
lambda_version.Description = self.VersionDescription
# Copy the same runtime policy for the version and the function
lambda_version.RuntimeManagementConfig = function.RuntimeManagementConfig

return lambda_version

Expand Down
3 changes: 0 additions & 3 deletions tests/translator/output/aws-cn/function_with_runtime_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,9 +229,6 @@
"Properties": {
"FunctionName": {
"Ref": "FunctionWithRuntimeManagementConfigAndAlias"
},
"RuntimeManagementConfig": {
"UpdateRuntimeOn": "Auto"
}
},
"Type": "AWS::Lambda::Version"
Expand Down
6 changes: 0 additions & 6 deletions tests/translator/output/aws-cn/globals_for_function.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,6 @@
"Properties": {
"FunctionName": {
"Ref": "FunctionWithOverrides"
},
"RuntimeManagementConfig": {
"UpdateRuntimeOn": "FunctionChange"
}
},
"Type": "AWS::Lambda::Version"
Expand Down Expand Up @@ -262,9 +259,6 @@
"Properties": {
"FunctionName": {
"Ref": "MinimalFunction"
},
"RuntimeManagementConfig": {
"UpdateRuntimeOn": "Auto"
}
},
"Type": "AWS::Lambda::Version"
Expand Down
3 changes: 0 additions & 3 deletions tests/translator/output/aws-us-gov/function_with_runtime_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,9 +229,6 @@
"Properties": {
"FunctionName": {
"Ref": "FunctionWithRuntimeManagementConfigAndAlias"
},
"RuntimeManagementConfig": {
"UpdateRuntimeOn": "Auto"
}
},
"Type": "AWS::Lambda::Version"
Expand Down
6 changes: 0 additions & 6 deletions tests/translator/output/aws-us-gov/globals_for_function.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,6 @@
"Properties": {
"FunctionName": {
"Ref": "FunctionWithOverrides"
},
"RuntimeManagementConfig": {
"UpdateRuntimeOn": "FunctionChange"
}
},
"Type": "AWS::Lambda::Version"
Expand Down Expand Up @@ -262,9 +259,6 @@
"Properties": {
"FunctionName": {
"Ref": "MinimalFunction"
},
"RuntimeManagementConfig": {
"UpdateRuntimeOn": "Auto"
}
},
"Type": "AWS::Lambda::Version"
Expand Down
3 changes: 0 additions & 3 deletions tests/translator/output/function_with_runtime_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,9 +229,6 @@
"Properties": {
"FunctionName": {
"Ref": "FunctionWithRuntimeManagementConfigAndAlias"
},
"RuntimeManagementConfig": {
"UpdateRuntimeOn": "Auto"
}
},
"Type": "AWS::Lambda::Version"
Expand Down
6 changes: 0 additions & 6 deletions tests/translator/output/globals_for_function.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,6 @@
"Properties": {
"FunctionName": {
"Ref": "FunctionWithOverrides"
},
"RuntimeManagementConfig": {
"UpdateRuntimeOn": "FunctionChange"
}
},
"Type": "AWS::Lambda::Version"
Expand Down Expand Up @@ -262,9 +259,6 @@
"Properties": {
"FunctionName": {
"Ref": "MinimalFunction"
},
"RuntimeManagementConfig": {
"UpdateRuntimeOn": "Auto"
}
},
"Type": "AWS::Lambda::Version"
Expand Down