Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Input transformer for AWS::Serverless::Function.EventBridgeRule #3283

Merged
merged 10 commits into from
Aug 2, 2023

Conversation

ConnorRobertson
Copy link
Contributor

Issue #, if available

#2666

Description of changes

Adding Input Transformer property to AWS::Serverless::Function.EventBridgeRule

Description of how you validated changes

Transformed a template that contains Input Transformer in an EventBridgeRule. Then deployed the template.

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ConnorRobertson ConnorRobertson requested a review from a team as a code owner August 1, 2023 17:35
@ConnorRobertson ConnorRobertson changed the title feat: Input transformer for AWS::Serverless::Function feat: Input transformer for AWS::Serverless::Function.EventBridgeRule Aug 1, 2023
Copy link
Member

@awood45 awood45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good (assuming we've also done an end to end deployed test with our test template) but let's make sure to add documentation.

@ConnorRobertson ConnorRobertson merged commit a040f3c into develop Aug 2, 2023
8 checks passed
@ConnorRobertson ConnorRobertson deleted the Input-Transformer branch August 2, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants