-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade ruff/black/mypy and fix violations #3300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update! It's great to see your PR!
Though I'm aware of performance tuning for %s
in logger, I believe that f-strings are more readable. I'm not sure that in our case we should prioritize performance over readability. I'd keep f-strings and disable the rule that says otherwise. I wonder what others think
No strong opinion on that, reverted those |
Thanks for the quick review man @ssenchenko 馃樃 |
Issue #, if available
Description of changes
noqa
only supports rule code, not name, so previouslynoqa
suppresses every rule if used 馃Description of how you validated changes
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam init
through aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.