Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade ruff/black/mypy and fix violations #3300

Merged
merged 14 commits into from
Aug 15, 2023

Conversation

aahung
Copy link
Contributor

@aahung aahung commented Aug 11, 2023

Issue #, if available

Description of changes

  • noqa only supports rule code, not name, so previously noqa suppresses every rule if used 馃
  • Upgrade ruff/black/mypy to latest version
  • Fix violations if possible
  • Disable a rule with too many violations

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aahung aahung marked this pull request as ready for review August 11, 2023 21:18
@aahung aahung requested a review from a team as a code owner August 11, 2023 21:18
Copy link
Contributor

@ssenchenko ssenchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update! It's great to see your PR!

Though I'm aware of performance tuning for %s in logger, I believe that f-strings are more readable. I'm not sure that in our case we should prioritize performance over readability. I'd keep f-strings and disable the rule that says otherwise. I wonder what others think

samtranslator/intrinsics/resolver.py Show resolved Hide resolved
@aahung
Copy link
Contributor Author

aahung commented Aug 12, 2023

Thank you for the update! It's great to see your PR!

Though I'm aware of performance tuning for %s in logger, I believe that f-strings are more readable. I'm not sure that in our case we should prioritize performance over readability. I'd keep f-strings and disable the rule that says otherwise. I wonder what others think

No strong opinion on that, reverted those

@aahung
Copy link
Contributor Author

aahung commented Aug 12, 2023

Thanks for the quick review man @ssenchenko 馃樃

@aahung aahung changed the title chore: Upgrade ruff/black and fix violations chore: Upgrade ruff/black/mypy and fix violations Aug 12, 2023
@aaythapa aaythapa enabled auto-merge (squash) August 14, 2023 21:09
@aaythapa aaythapa merged commit 00245b6 into aws:develop Aug 15, 2023
8 checks passed
@aahung aahung deleted the upgrade-ruff branch August 15, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants