-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add TimeoutInMillis Property to API Event Source #3310
Conversation
samtranslator/internal/schema_source/aws_serverless_function.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think globals can be implemented in this PR too, just to have everything roll out at once. Unless we have a good reason not to?
|
LGTM! |
Issue #, if available
Feature request discussion: #3287
Description of changes
Add TimeoutInMillis Property to API Event Source (currently only supported for HTTP API Event Source).
Example:
Description of how you validated changes
Validated with transform tests and integration tests. Transformed template with added TimeoutInMillis property, then deployed it successfully. Added integration test also verifies that the TimeoutInMillis property is set to the expected value from the template.
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam init
through aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.