Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support both 'VPCEndpointIds' and 'VpcEndpointIds' #3315

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Aug 22, 2023

Issue #, if available

Description of changes

SAM API EndpointConfiguration uses VPCEndpointIds but API Gateway EndpointConfiguration uses VpcEndpointIds. Support when either is defined but deny when both are defined.

Description of how you validated changes

Added new tests and all existing tests pass.

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@GavinZZ GavinZZ requested a review from a team as a code owner August 22, 2023 18:11
@GavinZZ GavinZZ merged commit e3e2e26 into aws:develop Aug 22, 2023
8 checks passed
@GavinZZ GavinZZ deleted the support_vpc_endpoint branch August 22, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants