Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix availability dip in PropagateTags property #3316

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Aug 22, 2023

Issue #, if available

Description of changes

Dip fix on PropagateTags property.

Description of how you validated changes

All tests passed.

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@GavinZZ GavinZZ requested a review from a team as a code owner August 22, 2023 19:11
Copy link
Contributor

@ssenchenko ssenchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a test?

@GavinZZ
Copy link
Contributor Author

GavinZZ commented Aug 22, 2023

The reason I did not add a test is because We do validation on template which caused

    def on_before_transform_template(self, template_dict):  # type: ignore[no-untyped-def]
        """
        Hook method that runs before a template gets transformed. In this method, we parse and process Globals section
        from the template (if present).
    
        :param dict template_dict: SAM template as a dictionary
        """
        try:
            global_section = Globals(template_dict)
        except InvalidGlobalsSectionException as ex:
>           raise InvalidDocumentException([ex]) from ex
E           samtranslator.model.exceptions.InvalidDocumentException: [InvalidGlobalsSectionException('Globals', 'Value of ${section} must be a dictionary')]

I think it's a trivial enough task and it is not worth the trouble to figure out how to bypass it and add this test.

@GavinZZ GavinZZ merged commit e323efc into aws:develop Aug 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants