chore: Remove Validation on DeletionPolicy and UpdateReplacePolicy #3317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssenchenko
approved these changes
Aug 22, 2023
ConnorRobertson
approved these changes
Aug 22, 2023
xazhao
approved these changes
Aug 22, 2023
awood45
reviewed
Aug 22, 2023
awood45
approved these changes
Aug 22, 2023
Fix linting issues Format file Format file
GavinZZ
force-pushed
the
remove_deletion_policy_validation
branch
from
72b8ef7
to
8376a53
Compare
ssenchenko
reviewed
Aug 22, 2023
integration/resources/templates/combination/function_with_intrinsics_resource_attribute.yaml
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
Description of changes
CloudFormation now supports intrinsics in
DeletionPolicyandUpdateReplacePolicy. SAM transform is enforcing a (now incorrect) validation on all DeletionPolicy fields that's preventing us from using intrinsic functions there. The transform doesn't need to process those values, it just needs to pass them through. CFN has updated their core language to permit this use caseDescription of how you validated changes
Shouldn't have impact on any existing SAM behaviour. All current tests pass
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.