chore: Update Lambda node runtime envs in integ tests #3320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssenchenko
approved these changes
Aug 23, 2023
gracelu0
approved these changes
Aug 23, 2023
xazhao
approved these changes
Aug 23, 2023
|
How about transform tests? |
|
personally, I don't think it's important if we have old version mentioned somewhere in transform tests. they never actually run and node can be there only for the sake of Lambda definition |
|
Transform tests don't matter right because we're not deploying it so even if create lambda deprecates node16, our trasnform tests aren't affected. |
GavinZZ
added a commit
to GavinZZ/serverless-application-model
that referenced
this pull request
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
Description of changes
Node 16 is deprecating soon. Update all integ test runtime to node 18.
Description of how you validated changes
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.