[fix] Auth Override not working with DefinitionBody fix #3328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaythapa
reviewed
Aug 31, 2023
samtranslator/internal/schema_source/aws_serverless_function.py
Outdated
Show resolved
Hide resolved
tests/translator/input/api_with_swagger_authorizer_none_test_auth_override.yaml
Outdated
Show resolved
Hide resolved
tests/translator/input/api_with_swagger_authorizer_none_test_auth_override.yaml
Outdated
Show resolved
Hide resolved
GavinZZ
reviewed
Aug 31, 2023
bentvelj
reviewed
Sep 5, 2023
GavinZZ
approved these changes
Sep 5, 2023
GavinZZ
changed the title
ssenchenko
reviewed
Sep 5, 2023
aaythapa
reviewed
Sep 5, 2023
tests/translator/input/api_with_swagger_authorizer_none_override_api_auth.yaml
Outdated
Show resolved
Hide resolved
UX review is finished, the property name has been approved and is okay to merge once this PR is approved. I will remove the [DO NOT MERGE]. |
paulhcsun
changed the title
|
Due to limited support for intrinsic functions in SAM templates, we will not be supporting intrinsics for the new property |
aaythapa
approved these changes
Sep 8, 2023
ssenchenko
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
Description of changes
Adding new optional opt-in property
OverrideApiAuthwith abooleanvalue to theAWS::Serverless::FunctionEventslevel.Description of how you validated changes
Transformation test
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.