-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Append CodeSha256 Value to Description #3337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I understand it correctly that you're saying that updating Description
will cause redeployment?
1d460b9
to
0cff40c
Compare
How about adding a test for when there is already a description and one for a description with an intrinsic in it? |
Added |
Btw, this was a breaking change since this caused some of our Lambda function descriptions to now be longer than the max length of 256, and deployment failed. Now we have to shorten our descriptions to compensate... something to be aware of for the future. |
Issue #, if available
Description of changes
Append the value of CodeSha256 to end of Lambda Function description. This would cause an update to the existing users who use codesha256 but since it will always create a new lambda version, it wouldn't cause any downtime for users.
Additionally add
DeletionPolicy
andUpdateReplacePolicy
to an integ test.Description of how you validated changes
All tests passed.
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam init
through aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.