Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Catch network interface deletion failure #3353

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Sep 26, 2023

Issue #, if available

Description of changes

Catch network interface deletion failure. We should not throw an error when we failed to delete an unused network interface.

Description of how you validated changes

N/A

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@GavinZZ GavinZZ marked this pull request as ready for review September 26, 2023 19:01
@GavinZZ GavinZZ requested a review from a team as a code owner September 26, 2023 19:01
@GavinZZ GavinZZ enabled auto-merge (squash) September 26, 2023 19:10
@GavinZZ GavinZZ merged commit f4648d0 into aws:develop Sep 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants