Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip SAR tests if python version > 3.10 #3379

Merged
merged 4 commits into from
Oct 11, 2023
Merged

fix: skip SAR tests if python version > 3.10 #3379

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
851a0c8
skip SAR tests if python version >3.10
aaythapa Oct 11, 2023
5ba1f48
format fix
aaythapa Oct 11, 2023
f1185f0
skip more tests
aaythapa Oct 11, 2023
b06870b
skip less tests
aaythapa Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/plugins/application/test_serverless_app_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import sys
from unittest import TestCase
from unittest.mock import Mock, patch

import boto3
import pytest
from botocore.exceptions import ClientError
from samtranslator.model.exceptions import InvalidResourceException
from samtranslator.plugins.application.serverless_app_plugin import ServerlessAppPlugin
Expand Down Expand Up @@ -51,6 +53,7 @@ def mock_get_region(self, service_name, region_name):
return "us-east-1"


@pytest.mark.skipif(sys.version_info > (3, 10), reason="Test fails for python versions >3.10")
class TestServerlessAppPlugin_init(TestCase):
def setUp(self):
client = boto3.client("serverlessrepo", region_name="us-east-1")
Expand Down Expand Up @@ -115,6 +118,7 @@ def test_not_used_when_sar_client_provided(self):
self.client_mock.assert_not_called()


@pytest.mark.skipif(sys.version_info > (3, 10), reason="Test fails for python versions >3.10")
class TestServerlessAppPlugin_on_before_transform_template_translate(TestCase):
def setUp(self):
client = boto3.client("serverlessrepo", region_name="us-east-1")
Expand Down