Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace nodejs14.x with nodejs18.x #3401

Merged
merged 2 commits into from
Nov 3, 2023
Merged

chore: replace nodejs14.x with nodejs18.x #3401

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49a4878
chore: replace nodejs14.x with nodejs18.x
xazhao Nov 3, 2023
86d02e6
Remove unexpected changes
xazhao Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/run_cfn_lint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/sh
set -eux

VENV=.venv_cfn_lint
VENV=.venv

# Install to separate venv to avoid circular dependency; cfn-lint depends on samtranslator
# See https://github.com/aws/serverless-application-model/issues/1042
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/api_merge_definitions_global.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Resources:
Type: AWS::Serverless::Function
Properties:
Handler: index.handler
Runtime: nodejs14.x
Runtime: nodejs18.x
InlineCode: |
exports.handler = async (event, context, callback) => {
return {
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/api_merge_definitions_with_conflicting_auth.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Resources:
Type: AWS::Serverless::Function
Properties:
Handler: index.handler
Runtime: nodejs14.x
Runtime: nodejs18.x
InlineCode: |
exports.handler = async (event, context, callback) => {
return {
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/api_merge_definitions_with_conflicting_methods.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Resources:
Type: AWS::Serverless::Function
Properties:
Handler: index.handler
Runtime: nodejs14.x
Runtime: nodejs18.x
InlineCode: |
exports.handler = async (event, context, callback) => {
return {
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/api_merge_definitions_with_conflicting_request_models.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Resources:
Type: AWS::Serverless::Function
Properties:
Handler: index.handler
Runtime: nodejs14.x
Runtime: nodejs18.x
InlineCode: |
exports.handler = async (event, context, callback) => {
return {
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/api_merge_definitions_with_different_methods.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Resources:
Type: AWS::Serverless::Function
Properties:
Handler: index.handler
Runtime: nodejs14.x
Runtime: nodejs18.x
InlineCode: |
exports.handler = async (event, context, callback) => {
return {
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/api_merge_definitions_with_full_properties.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Resources:
Type: AWS::Serverless::Function
Properties:
Handler: index.handler
Runtime: nodejs14.x
Runtime: nodejs18.x
InlineCode: |
exports.handler = async (event, context, callback) => {
return {
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/api_with_custom_domain_regional.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Resources:
return response;
};
Handler: index.handler
Runtime: nodejs14.x
Runtime: nodejs18.x
Events:
ImplicitGet:
Type: Api
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/api_with_custom_domains_edge.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Resources:
return response;
};
Handler: index.handler
Runtime: nodejs14.x
Runtime: nodejs18.x
Events:
Fetch:
Type: Api
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/api_with_custom_domains_regional.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Resources:
return response;
};
Handler: index.handler
Runtime: nodejs14.x
Runtime: nodejs18.x
Events:
ImplicitGet:
Type: Api
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/api_with_custom_domains_regional_latency_routing.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Resources:
return response;
};
Handler: index.handler
Runtime: nodejs14.x
Runtime: nodejs18.x
Events:
ImplicitGet:
Type: Api
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/api_with_custom_domains_regional_latency_routing_ipv6.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Resources:
return response;
};
Handler: index.handler
Runtime: nodejs14.x
Runtime: nodejs18.x
Events:
ImplicitGet:
Type: Api
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/api_with_custom_domains_regional_ownership_verification.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Resources:
return response;
};
Handler: index.handler
Runtime: nodejs14.x
Runtime: nodejs18.x
Events:
ImplicitGet:
Type: Api
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/api_with_request_parameters_openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Resources:
});
}
Handler: index.handler
Runtime: nodejs14.x
Runtime: nodejs18.x
Events:
GetHtml:
Type: Api
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/congito_userpool_with_sms_configuration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Resources:
Properties:
CodeUri: s3://bucket/key
Handler: app.handler
Runtime: nodejs14.x
Runtime: nodejs18.x
Events:
CognitoUserPoolPreSignup:
Type: Cognito
Expand Down
4 changes: 2 additions & 2 deletions tests/translator/input/connector_api_to_function.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Resources:
MyServerlessFunction:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
InlineCode: |
const AWS = require('aws-sdk');
Expand All @@ -58,7 +58,7 @@ Resources:
Type: AWS::Lambda::Function
Properties:
Role: !GetAtt MyRole.Arn
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
Code:
ZipFile: |
Expand Down
4 changes: 2 additions & 2 deletions tests/translator/input/connector_api_to_multiple_function.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Resources:
MyServerlessFunction:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
InlineCode: |
const AWS = require('aws-sdk');
Expand All @@ -31,7 +31,7 @@ Resources:
Type: AWS::Lambda::Function
Properties:
Role: !GetAtt MyRole.Arn
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
Code:
ZipFile: |
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/connector_appsync_api_to_lambda.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ Resources:
}
}
PackageType: Zip
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
2 changes: 1 addition & 1 deletion tests/translator/input/connector_appsync_to_lambda.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Resources:
return "Hello World"
}
Handler: index.handler
Runtime: nodejs14.x
Runtime: nodejs18.x

AppSyncApi:
Type: AWS::AppSync::GraphQLApi
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/connector_bucket_to_function.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Resources:
Function:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
InlineCode: |
const AWS = require('aws-sdk');
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/connector_function_to_location.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Resources:
MyFunction:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
InlineCode: |
const AWS = require('aws-sdk');
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/connector_function_to_multiple_s3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Resources:
MyFunction:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
InlineCode: |
const AWS = require('aws-sdk');
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/connector_function_to_s3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Resources:
MyFunction:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
InlineCode: |
const AWS = require('aws-sdk');
Expand Down
4 changes: 2 additions & 2 deletions tests/translator/input/connector_function_to_sqs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Resources:
Type: AWS::Lambda::Function
Properties:
Role: !GetAtt MyRole.Arn
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
Code:
ZipFile: |
Expand All @@ -30,7 +30,7 @@ Resources:
MyServerlessFunction:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
InlineCode: |
const AWS = require('aws-sdk');
Expand Down
4 changes: 2 additions & 2 deletions tests/translator/input/connector_function_to_table.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Resources:
Type: AWS::Lambda::Function
Properties:
Role: !GetAtt MyRole.Arn
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
Code:
ZipFile: |
Expand All @@ -32,7 +32,7 @@ Resources:
MyServerlessFunction:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
InlineCode: |
const AWS = require('aws-sdk');
Expand Down
4 changes: 2 additions & 2 deletions tests/translator/input/connector_mix_destination.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Resources:
TriggerFunction:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
Timeout: 10 # in case eb has delay
InlineCode: |
Expand Down Expand Up @@ -54,7 +54,7 @@ Resources:
Function:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
InlineCode: |
const AWS = require('aws-sdk');
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/connector_sfn_to_function.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Resources:
MyFunction:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
InlineCode: |
const AWS = require('aws-sdk');
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/connector_sfn_to_function_without_policy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Resources:
MyFunction:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
InlineCode: |
exports.handler = async (event) => {
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/connector_sns_to_function.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Resources:
Type: AWS::Lambda::Function
Properties:
Role: !GetAtt MyRole.Arn
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
Code:
ZipFile: |
Expand Down
4 changes: 2 additions & 2 deletions tests/translator/input/connector_sqs_to_function.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Resources:
TriggerFunction:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
Timeout: 10 # in case eb has delay
InlineCode: |
Expand Down Expand Up @@ -39,7 +39,7 @@ Resources:
InvokedFunction:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
InlineCode: |
const AWS = require('aws-sdk');
Expand Down
4 changes: 2 additions & 2 deletions tests/translator/input/connector_sqs_to_multiple_function.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Resources:
InvokedFunction:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
InlineCode: |
const AWS = require('aws-sdk');
Expand All @@ -26,7 +26,7 @@ Resources:
InvokedFunction2:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
InlineCode: |
const AWS = require('aws-sdk');
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/connector_table_to_function.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Resources:
Type: AWS::Lambda::Function
Properties:
Role: !GetAtt MyRole.Arn
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
Code:
ZipFile: |
Expand Down
4 changes: 2 additions & 2 deletions tests/translator/input/connector_table_to_function_read.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Resources:
TriggerFunction:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
Timeout: 10 # in case eb has delay
InlineCode: |
Expand Down Expand Up @@ -36,7 +36,7 @@ Resources:
InvokedFunction:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
InlineCode: |
const AWS = require('aws-sdk');
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/connector_with_non_id_source_and_destination.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Resources:
SamFunction:
Type: AWS::Serverless::Function
Properties:
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
Role: !GetAtt MyRole.Arn
InlineCode: |
Expand Down
2 changes: 1 addition & 1 deletion tests/translator/input/embedded_connector_function_to_multi_dest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Resources:
- Read
- Write
Properties:
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
InlineCode: |
const AWS = require('aws-sdk');
Expand Down
Loading