Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Msk Tests Failure due to Missing Permissions #3443

Merged
merged 3 commits into from Nov 23, 2023
Merged

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Nov 23, 2023

Issue #, if available

Description of changes

MSK tests failure due to missing ListBucket permission and MSK Cluster did not stablize.
The permission issue needs to be fixed
The second issue is expected and the root cause of flakiness. Added comment to explain it.

Description of how you validated changes

All tests pass.

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@GavinZZ GavinZZ marked this pull request as ready for review November 23, 2023 19:25
@GavinZZ GavinZZ requested a review from a team as a code owner November 23, 2023 19:25
@GavinZZ GavinZZ changed the title Msk fix fix: Msk Tests Failure due to Missing Permissions Nov 23, 2023
@GavinZZ GavinZZ enabled auto-merge (squash) November 23, 2023 20:35
@GavinZZ GavinZZ merged commit bcfe4ba into aws:develop Nov 23, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants