Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix resource for CodePipelineLambdaExecutionPolicy policy template #548

Merged
merged 4 commits into from
Aug 10, 2018

Conversation

Tanbouz
Copy link
Contributor

@Tanbouz Tanbouz commented Aug 10, 2018

Closes #389

Description of changes:
PutJobFailureResult & PutJobSuccessResult do not support resource-level permissions and require you to choose All resources.

You specify the actions in the policy's Action field, and you specify a wildcard character (*) as the resource value in the policy's Resource field.

https://docs.aws.amazon.com/codepipeline/latest/userguide/permissions-reference.html

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. 馃憤

`PutJobFailureResult` & `PutJobSuccessResult` do not support resource-level permissions and require you to choose All resources.

https://docs.aws.amazon.com/codepipeline/latest/userguide/permissions-reference.html

aws#389
@brettstack
Copy link
Contributor

Copy link
Contributor

@brettstack brettstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I'll get this into our next release.

Copy link
Contributor

@keetonian keetonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! Thank you also for the link to the AWS docs explaining why this change is necessary!

@brettstack brettstack merged commit 95c27e6 into aws:develop Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants