docs: update example apps to use policy templates and parameters #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a testing section to your PR description? Just wondering if you actually tried to deploy these updates. |
keetonian
suggested changes
Aug 28, 2018
keetonian
reviewed
Aug 29, 2018
|
@jlhood @keetonian I'm going to test several of these, but will rely on end-to-end testing when it comes time to redeploy these to the app repo. |
keetonian
approved these changes
Aug 29, 2018
jlhood
suggested changes
Aug 30, 2018
There was a problem hiding this comment.
Overall I really appreciate the readability improvements of the policy templates! Some blockers though:
- Need to remove all Name Metadata fields (remove entire Metadata section if Name is the only field in it)
- Looks like there's a script that shouldn't be part of this PR.
| @@ -1,6 +1,11 @@ | |||
| AWSTemplateFormatVersion: '2010-09-09' | |||
| Transform: 'AWS::Serverless-2016-10-31' | |||
| Description: 'Blueprint for CloudFront ab testing, implemented in NodeJS.' | |||
| Metadata: | |||
| Name: cloudfrontabtest | |||
There was a problem hiding this comment.
Remove this metadata. It'll actually cause publish to fail because the published name (cloudfront-ab-test) does not match this field. Should just remove the metadata completely.
examples/apps/update-apps.js
Outdated
| const bluePrintAppDirectories = readdirSync(bluePrintsDirectory) | ||
| const ignore = ['.DS_Store', 'mass-pub'] | ||
| const appIgnore = ['node_modules'] | ||
| bluePrintAppDirectories.forEach(blueprintAppDirectoryName => { |
There was a problem hiding this comment.
This script doesn't seem like it belongs in this PR. Remove?
honglu
approved these changes
Sep 4, 2018
jlhood
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.