Expose skill ID for event source validation with skills #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing! It looks like the Travis build is failing due to outdated dependencies that we fixed on develop (#570) but haven't yet merged to master. Could you rebase onto develop and resubmit a PR? Otherwise, this looks great! |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Allows users to optionally specify their skill ID when configuring an AlexaSkillEvent on a function. This will validate that the Lambda is called by the expected skill and is strongly recommended by Alexa.
I am open to changing the name to match the underlying CF property (EventSourceToken), but given this property must be the skill ID in this application I think this is a more sensible abstraction.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.