Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example [lambda_safe_deployments] use nodejs8.10 for the PreTraffic hook #605

Merged
merged 2 commits into from
May 2, 2019
Merged

example [lambda_safe_deployments] use nodejs8.10 for the PreTraffic hook #605

merged 2 commits into from
May 2, 2019

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Oct 1, 2018

Issue #, if available:

n/a

Description of changes:

PreTrafficHook example now uses NodeJS 8.10 runtime

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@keetonian keetonian changed the base branch from master to develop October 1, 2018 16:13
keetonian
keetonian previously approved these changes Oct 1, 2018
View reviewed changes
Copy link
Contributor

@keetonian keetonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much neater. Thank you for this update!

@sullis
Copy link
Contributor Author

sullis commented Oct 1, 2018

awesome

@sullis sullis force-pushed the example-preTrafficHook-nodejs8.10 branch from d995564 to d76f981 Compare February 18, 2019 19:15
@sullis sullis changed the base branch from develop to master February 18, 2019 19:20
@sullis sullis force-pushed the example-preTrafficHook-nodejs8.10 branch from d76f981 to 3c1be7c Compare February 18, 2019 19:29
@codecov-io
Copy link

codecov-io commented Feb 18, 2019 •
edited
Loading

Codecov Report

Merging #605 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #605   +/-   ##
========================================
  Coverage    94.65%   94.65%           
========================================
  Files           69       69           
  Lines         3011     3011           
  Branches       559      559           
========================================
  Hits          2850     2850           
  Misses          85       85           
  Partials        76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 166304b...f664535. Read the comment docs.

@sullis sullis force-pushed the example-preTrafficHook-nodejs8.10 branch 2 times, most recently from 1c61e43 to 030c16f Compare February 19, 2019 00:51
jlhood
jlhood suggested changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sullis Thanks so much for contributing this change! There are still a few things to address:

  1. All changes should be made against the develop branch, not master. Please rebase your changes onto the latest develop and switch the base of this PR to develop.
  2. Please address @brettstack's comment on properly returning an error in the exception case. Currently, it's returning a string which Lambda will take as success. Previously, the example returned a response that indicated failure.

@sullis
Copy link
Contributor Author

sullis commented May 1, 2019

WDYT? @brettstack

@jlhood jlhood changed the base branch from master to develop May 2, 2019 17:49
@jlhood
Copy link
Contributor

jlhood commented May 2, 2019

@sullis Thanks for the update! I changed the base branch of this PR to develop instead of master. Can you rebase your changes onto latest develop so it can be merged?

@sullis sullis force-pushed the example-preTrafficHook-nodejs8.10 branch from af27b79 to f664535 Compare May 2, 2019 17:52
@sullis
Copy link
Contributor Author

sullis commented May 2, 2019

@sullis Thanks for the update! I changed the base branch of this PR to develop instead of master. Can you rebase your changes onto latest develop so it can be merged?

Done.

@jlhood jlhood merged commit bd10d0e into aws:develop May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlhood jlhood jlhood approved these changes

@brettstack brettstack brettstack approved these changes

@keetonian keetonian keetonian left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sullis @codecov-io @jlhood @brettstack @keetonian