Fix s3 examples #632
Merged
Fix s3 examples #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s3 Buckets and lambdas were being generated but lambda didn't have permissions for s3 buckets. Started using prefix and Sub to intrinsically tie them together to circumvent circular dependency issues.
keetonian
approved these changes
Oct 25, 2018
brettstack
approved these changes
Oct 26, 2018
|
Thanks! @keetonian can we merge this direct to master? |
|
@brettstack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#618
Description of changes:
Modified examples to create and grant read access to S3 Buckets created, these examples now can work out of the box. Needed to use !Sub and Prefix to get around circular dependency issues.
Based solution on method described here
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.