Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Access log and canary setting support to templates. #643

Merged
merged 7 commits into from
Oct 26, 2018

Conversation

tryantwit
Copy link
Contributor

Issue #, if available:
#612
Description of changes:
Added samtranslator support for AccessLogSetting and CanarySetting to Api Gateway.
Translator tests updated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@keetonian keetonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this pull request! Could you also add into the documentation that SAM now supports these properties? Add it into the versions/2016-10-31.md file

Copy link
Contributor

@keetonian keetonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! This looks good to me!

@jlhood jlhood merged commit 8d8a53b into aws:develop Oct 26, 2018
Copy link
Contributor

@dhruvsood dhruvsood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@jvanbrunschot-coolblue
Copy link

Can we release this :)

@brettstack
Copy link
Contributor

#516

@anishsam
Copy link

Hi,

When will this be available? I see this documented in https://github.com/awslabs/serverless-application-model/blob/develop/versions/2016-10-31.md, however when I tried with sam verify, it fails.

Error: [InvalidResourceException('ApiGwBookstoreApi', 'property AccessLogSetting not defined for resource of type AWS::Serverless::Api')] ('ApiGwBookstoreApi', 'property AccessLogSetting not defined for resource of type AWS::Serverless::Api')

@keetonian
Copy link
Contributor

It will be available with the next release. It is merged into develop right now, we will prepare a release and merge it to master to make it available in SAM

@alanwill
Copy link

Any idea when this will happen? Not to be a nag but it's misleading that it's showing up in the documentation when it really isn't released yet and looks like it's been like that for at least a month already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants