-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Access log and canary setting support to templates. #643
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this pull request! Could you also add into the documentation that SAM now supports these properties? Add it into the versions/2016-10-31.md file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! This looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Can we release this :) |
Hi, When will this be available? I see this documented in https://github.com/awslabs/serverless-application-model/blob/develop/versions/2016-10-31.md, however when I tried with sam verify, it fails. Error: [InvalidResourceException('ApiGwBookstoreApi', 'property AccessLogSetting not defined for resource of type AWS::Serverless::Api')] ('ApiGwBookstoreApi', 'property AccessLogSetting not defined for resource of type AWS::Serverless::Api') |
It will be available with the next release. It is merged into develop right now, we will prepare a release and merge it to master to make it available in SAM |
Any idea when this will happen? Not to be a nag but it's misleading that it's showing up in the documentation when it really isn't released yet and looks like it's been like that for at least a month already. |
Issue #, if available:
#612
Description of changes:
Added samtranslator support for AccessLogSetting and CanarySetting to Api Gateway.
Translator tests updated.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.