Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for X-Ray to AWS::Serverless::Api #657

Merged
merged 2 commits into from
Nov 29, 2018
Merged

Add support for X-Ray to AWS::Serverless::Api #657

merged 2 commits into from
Nov 29, 2018

Conversation

Dunedan
Copy link
Contributor

@Dunedan Dunedan commented Nov 12, 2018

CloudFormation recently got the ability to enable active tracing with X-Ray for API Gateway stages. This PR adds that ability to AWS::Serverless::Api.

I hope I updated it in all necessary places, including documentation etc., but if I didn't, please just tell me where it's missing and I'll update the PR accordingly. 馃槂

Fixes #581

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@keetonian keetonian self-assigned this Nov 28, 2018
Copy link
Contributor

@keetonian keetonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution!

Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks so much for contributing this!

@jlhood jlhood merged commit a35cadc into aws:develop Nov 29, 2018
@vinaykasina
Copy link

Hi, when can this be pushed to master?

@jlhood
Copy link
Contributor

jlhood commented Dec 5, 2018

@vinaykasina We can't give exact release dates so the best we can say is it will be released "soon".

@Dunedan Dunedan deleted the api-gateway-xray-support branch March 21, 2019 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add x-ray enable flag to API gateway
4 participants