Allow Api.Auth in Globals section

[sjawhar]

#512 added the ability to set API auth, and the original issue outlined including in the Globals section. However, it looks like the Globals checker actually is excluding Auth as one of the supported properties. Is there a reason that is so? I figured opening a PR was a quick and easy way to start a discussion as well as move toward a fix. Looking forward to your feedback!

[keetonian]

Thank you for submitting this! Could you review why the tests aren't passing and fix them?

[codecov-io]

Codecov Report

Merging #682 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #682   +/-   ##
========================================
  Coverage    94.17%   94.17%           
========================================
  Files           67       67           
  Lines         2678     2678           
  Branches       478      478           
========================================
  Hits          2522     2522           
  Misses          80       80           
  Partials        76       76

Impacted Files	Coverage Δ
samtranslator/plugins/globals/globals.py	100% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc9a3b7...ffcee0c. Read the comment docs.

[sjawhar]

No problem, it was an expected error message that needed updating. This doesn't necessarily address the need for new tests, though. If you think they are needed, please point me to where I can get started.

[keetonian]

Hi! Thanks for fixing that! Could you also add a success-case test? It should be as simple as adding an Auth section (see example in this test) to the globals-for-api test, then fixing the test output to match the new expected behavior.

[sjawhar]

I've added the Auth section to the globals_for_api test. Now it looks like the test is failing because unicode is causing the match assertion to fail. Here's a snippet:

Any tips?

[keetonian]

I'll take a look, I haven't seen this before.

[keetonian]

I updated the tests- needed to change some of the hashes on the deployments as well as add in the security sections

[keetonian]

Tests pass in py36 but not py27. Investigating

[jlhood]

@brettstack Could you review this one? Just wanted to sanity check that you hadn't intentionally excluded Api.Auth from globals for a reason.

[cadetstar]

Is there an ETA for this getting published and available for use? Alternately, can I override the branch aws-sam-cli uses locally to validate the template?