Event source disabled #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Controls whether the lambda function should begin polling the event source.
Events that utilize pull are: * SQS * DynamoDB Streams * Kinesis
keetonian
requested review from
brettstack,
jlhood and
keetonian
and removed request for
brettstack
keetonian
approved these changes
Dec 5, 2018
jlhood
approved these changes
Dec 5, 2018
|
Isn't it useful to replicate this change for other types of events? Just found it useful for API in my case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #669
Description of changes:
Added Enabled boolean option for SQS, DynamoDB and Kinesis events.
Updated documentation to show support for this property addition.
Modified translator tests to verify that cloudformation templates generate with Enabled as part of AWS::Lambda::EventSourceMapping.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.