-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passing Condition to new LayerVersion and Application for #142 #707
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #707 +/- ##
===========================================
+ Coverage 94.17% 94.17% +<.01%
===========================================
Files 67 67
Lines 2676 2679 +3
Branches 477 478 +1
===========================================
+ Hits 2520 2523 +3
Misses 80 80
Partials 76 76
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a Condition to one of the tests (each) for Application and LayerVersion to verify that this works (as well as ensure it will work through future changes)?
This is awesome, by the way. Thank you so much for doing this! |
- added condition tests to basic cases Application and LayerVersion - renamed local var
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 😃
*Issue #142 *
Description of changes:
Pass passtrhough_resource_attributes when processing LayerVersion and Application
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.