Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing Condition to new LayerVersion and Application for #142 #707

Merged
merged 2 commits into from
Dec 7, 2018
Merged

Passing Condition to new LayerVersion and Application for #142 #707

merged 2 commits into from
Dec 7, 2018

Conversation

Jacco
Copy link
Contributor

@Jacco Jacco commented Dec 6, 2018

*Issue #142 *

Description of changes:

Pass passtrhough_resource_attributes when processing LayerVersion and Application

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Dec 6, 2018

Codecov Report

Merging #707 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #707      +/-   ##
===========================================
+ Coverage    94.17%   94.17%   +<.01%     
===========================================
  Files           67       67              
  Lines         2676     2679       +3     
  Branches       477      478       +1     
===========================================
+ Hits          2520     2523       +3     
  Misses          80       80              
  Partials        76       76
Impacted Files Coverage Δ
samtranslator/model/sam_resources.py 95.74% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40445a1...a5f542b. Read the comment docs.

Copy link
Contributor

@keetonian keetonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a Condition to one of the tests (each) for Application and LayerVersion to verify that this works (as well as ensure it will work through future changes)?

samtranslator/model/sam_resources.py Outdated Show resolved Hide resolved
@keetonian
Copy link
Contributor

This is awesome, by the way. Thank you so much for doing this!

- added condition tests to basic cases Application and LayerVersion
- renamed local var
Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😃

@jlhood jlhood merged commit dc9a3b7 into aws:develop Dec 7, 2018
keetonian added a commit to keetonian/serverless-application-model that referenced this pull request Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants