Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: turn on flake 8 #720

Merged
merged 2 commits into from Dec 14, 2018
Merged

chore: turn on flake 8 #720

merged 2 commits into from Dec 14, 2018

Conversation

keetonian
Copy link
Contributor

Issue #, if available:
#580
Description of changes:
Turn on flake8

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@keetonian
Copy link
Contributor Author

keetonian commented Dec 13, 2018 •
edited

These errors weren't showing up in my local testing. Will fix

@keetonian
Remove two more warnings
33cf5ce 
W504 is for logical operators at the end of a line, either this or
W503 needs to be removed (logical operators at beginning of line).

W605 is an invalid escape sequence; it's being used in a regex so it's
fine.
@codecov-io
Copy link

Codecov Report

Merging #720 into develop will decrease coverage by <.01%.
The diff coverage is 78.84%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #720      +/-   ##
===========================================
- Coverage    94.19%   94.18%   -0.01%     
===========================================
  Files           67       67              
  Lines         2686     2683       -3     
  Branches       478      478              
===========================================
- Hits          2530     2527       -3     
  Misses          80       80              
  Partials        76       76
Impacted Files Coverage Δ
samtranslator/plugins/api/implicit_api_plugin.py 100% <ø> (ø) ⬆️
...amtranslator/policy_template_processor/template.py 100% <ø> (ø) ⬆️
samtranslator/model/iam.py 81.25% <ø> (ø) ⬆️
samtranslator/model/s3.py 85.71% <ø> (ø) ⬆️
samtranslator/plugins/exceptions.py 83.33% <ø> (ø) ⬆️
samtranslator/validator/validator.py 95.23% <ø> (ø) ⬆️
samtranslator/translator/arn_generator.py 86.95% <ø> (ø) ⬆️
samtranslator/model/eventsources/pull.py 91.66% <ø> (ø) ⬆️
...nslator/model/preferences/deployment_preference.py 100% <ø> (ø) ⬆️
...slator/plugins/policies/policy_templates_plugin.py 100% <ø> (ø) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0865055...33cf5ce. Read the comment docs.

paoptu023
paoptu023 approved these changes Dec 14, 2018
View reviewed changes
Copy link

@paoptu023 paoptu023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray!

jlhood
jlhood approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@jlhood jlhood merged commit 9196f45 into aws:develop Dec 14, 2018
@brettstack brettstack mentioned this pull request Mar 6, 2019
Merged
@keetonian keetonian deleted the flake branch March 11, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlhood jlhood jlhood approved these changes

@paoptu023 paoptu023 paoptu023 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@keetonian @codecov-io @jlhood @paoptu023