Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding SES Email Template Crud Policy Template #723

Merged
merged 16 commits into from
Jan 29, 2019
Merged

Conversation

simalexan
Copy link
Contributor

@simalexan simalexan commented Dec 16, 2018

Description of changes:
Add SESEmailTemplateCrudPolicy which grants the user access to:

  • ses:CreateTemplate
  • ses:GetTemplate
  • ses:ListTemplates
  • ses:UpdateTemplate
  • ses:DeleteTemplate
  • ses:TestRenderTemplate

Thank you for taking this into consideration. I would be interested in adding more in the future.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@simalexan simalexan changed the title adding SES Create Template Policy Template adding SES Email Template Crud Policy Template Dec 17, 2018
@codecov-io
Copy link

codecov-io commented Dec 17, 2018

Codecov Report

Merging #723 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #723   +/-   ##
========================================
  Coverage    94.18%   94.18%           
========================================
  Files           67       67           
  Lines         2683     2683           
  Branches       478      478           
========================================
  Hits          2527     2527           
  Misses          80       80           
  Partials        76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa00bb1...e027e49. Read the comment docs.

Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only blocker is the question on scoping. If the IAM action doesn't support scoping to a specific resource, then this should be fine.

@simalexan
Copy link
Contributor Author

You have a good point! Will add, it makes sense as it’s for SES template operations

@jlhood jlhood merged commit 7cf48bd into aws:develop Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants