Add FilterLogEventsPolicy to policy templates. #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new policy to the policy templates that grants permission to call the filter-log-events API, given a Log Group.
To be able to access the Log Streams within a Log Group, the * is needed in the filter log events policy, so this commit adds it to the resource field.
…tream:* instead of logGroupName*.
Codecov Report
@@ Coverage Diff @@
## develop #729 +/- ##
========================================
Coverage 94.18% 94.18%
========================================
Files 67 67
Lines 2683 2683
Branches 478 478
========================================
Hits 2527 2527
Misses 80 80
Partials 76 76Continue to review full report at Codecov.
|
jlhood
suggested changes
Dec 19, 2018
There was a problem hiding this comment.
Thanks for doing this! Please also add this policy to the all_policy_templates.yaml example. See #715 as an example.
keetonian
approved these changes
Dec 19, 2018
jlhood
suggested changes
Dec 19, 2018
jlhood
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.