s3CrudPolicy allows using canned ACL for s3.PutObject #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #769 +/- ##
========================================
Coverage 94.18% 94.18%
========================================
Files 67 67
Lines 2683 2683
Branches 478 478
========================================
Hits 2527 2527
Misses 80 80
Partials 76 76Continue to review full report at Codecov.
|
keetonian
previously approved these changes
Jan 18, 2019
keetonian
approved these changes
Jan 18, 2019
jlhood
approved these changes
Jan 18, 2019
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: the old S3CrudPolicy would not allow s3.PutObject operations if they supplied a canned ACL (such as
public-read), because S3 also requires a PutObjectAcl permission for that. This pull request extends the S3CrudPolicy to allow canned ACLs in API requests to write objects.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.