-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/func/add ReservedConcurrentExecutions to globals #808
Feat/func/add ReservedConcurrentExecutions to globals #808
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #808 +/- ##
===========================================
- Coverage 94.85% 94.54% -0.31%
===========================================
Files 67 67
Lines 2952 2824 -128
Branches 576 508 -68
===========================================
- Hits 2800 2670 -130
- Misses 76 81 +5
+ Partials 76 73 -3
Continue to review full report at Codecov.
|
Thanks @merzwilliam! One final thing, could you please add this Global to this test https://github.com/awslabs/serverless-application-model/blob/master/tests/translator/input/globals_for_function.yaml. |
@brettstack - I apologize for taking so long to make this change! Should be good to go now =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this contribution!
Issue #, if available: #760
Description of changes: Added "ReservedConcurrentExecutions" to the list of supported global properties for the AWS::Serverless::Function resource. PR also includes updates to relevant tests and an update to the Globals support doc.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.