Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/func/add ReservedConcurrentExecutions to globals #808

Merged
merged 4 commits into from
Mar 22, 2019

Conversation

merzwilliam
Copy link
Contributor

Issue #, if available: #760

Description of changes: Added "ReservedConcurrentExecutions" to the list of supported global properties for the AWS::Serverless::Function resource. PR also includes updates to relevant tests and an update to the Globals support doc.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Feb 11, 2019

Codecov Report

Merging #808 into develop will decrease coverage by 0.3%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #808      +/-   ##
===========================================
- Coverage    94.85%   94.54%   -0.31%     
===========================================
  Files           67       67              
  Lines         2952     2824     -128     
  Branches       576      508      -68     
===========================================
- Hits          2800     2670     -130     
- Misses          76       81       +5     
+ Partials        76       73       -3
Impacted Files Coverage Δ
samtranslator/plugins/globals/globals.py 100% <ø> (ø) ⬆️
samtranslator/plugins/api/implicit_api_plugin.py 96.26% <0%> (-3.74%) ⬇️
samtranslator/model/api/api_generator.py 96.17% <0%> (-1.88%) ⬇️
samtranslator/model/eventsources/push.py 88.73% <0%> (-1.57%) ⬇️
samtranslator/model/intrinsics.py 94.44% <0%> (-1.02%) ⬇️
samtranslator/model/sam_resources.py 96.09% <0%> (-0.88%) ⬇️
samtranslator/sdk/resource.py 100% <0%> (ø) ⬆️
samtranslator/model/__init__.py 96.85% <0%> (+0.36%) ⬆️
samtranslator/swagger/swagger.py 98.32% <0%> (+0.39%) ⬆️
samtranslator/model/eventsources/pull.py 92% <0%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 651550c...d54e649. Read the comment docs.

@brettstack
Copy link
Contributor

Thanks @merzwilliam! One final thing, could you please add this Global to this test https://github.com/awslabs/serverless-application-model/blob/master/tests/translator/input/globals_for_function.yaml.

@merzwilliam
Copy link
Contributor Author

@brettstack - I apologize for taking so long to make this change! Should be good to go now =)

Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this contribution!

@jlhood jlhood merged commit 0fc2ca6 into aws:develop Mar 22, 2019
@merzwilliam merzwilliam deleted the feat/func/AddConcurrencyToGlobals branch March 22, 2019 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants