-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API Gateway IAM (AWS_IAM) Authorizers #827
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #827 +/- ##
===========================================
+ Coverage 94.56% 94.58% +0.02%
===========================================
Files 67 67
Lines 2834 2865 +31
Branches 508 519 +11
===========================================
+ Hits 2680 2710 +30
- Misses 82 83 +1
Partials 72 72
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome. Greatly appreciate the PR. A few minor comments; the largest one probably the scenario where Authorizers
isn't defined - I don't think that's necessary for AWS_IAM
Hey @brettstack, thank you for the review 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I just had a small request to add a code comment. All that's remaining is to update this doc https://github.com/awslabs/serverless-application-model/blob/master/versions/2016-10-31.md#awsserverlessapi with your new additions and we'll get them merged in. I'm super excited about getting this in and I many others are as well.
We'd also appreciate an example using AWS_IAM. If you're not up for it, we'll ask someone else if they'd like to have contribute one. See this example as a reference https://github.com/awslabs/serverless-application-model/tree/master/examples/2016-10-31/api_lambda_token_auth. |
Looks like I broke things with my last merge. I'll fix that. |
Hey, @brettstack @keetonian. I have fixed the conflicts and added the documentation and source comment.
Sorry, it is difficult for me to spend more time to do it, would be great if you can ask someone else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thank you!
Thanks @brettstack @keetonian 😄 |
Policy says we can't give dates, but I can say we want to get this and other features/fixes out asap. If you need it now, you can try using SAM CLI and these instructions for using a dev version of SAM https://github.com/awslabs/aws-sam-cli/blob/develop/DEVELOPMENT_GUIDE.md#4-optional-install-development-version-of-sam-transformer. Running |
@brettstack @horike37
and, under my AWS::Serverless::Api path method, I add a security item that points to the securityDefinition.
|
Issue #802 #781, if available:
Description of changes:
Add API Gateway IAM (AWS_IAM) Authorizers
Description of how you validated changes:
Please verify this PR with following the RFC of #781,
Checklist:
make pr
passesRegarding documentation, I didn't update those because I took a look at stuff under
doc
directory but I was not able to find related toAuthorizers
features. Ping me if missed it.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.