Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch improper event type errors #846

Merged
merged 3 commits into from
Mar 7, 2019

Conversation

keetonian
Copy link
Contributor

Issue #, if available:
N/A

Description of changes:
Catch invalid event type error

Description of how you validated changes:
Tested locally and added new translator test

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@keetonian keetonian changed the title catch improper event type errors fix: catch improper event type errors Mar 7, 2019
@codecov-io
Copy link

Codecov Report

Merging #846 into develop will increase coverage by 0.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #846      +/-   ##
===========================================
+ Coverage    94.54%   94.55%   +0.01%     
===========================================
  Files           67       67              
  Lines         2824     2830       +6     
  Branches       508      508              
===========================================
+ Hits          2670     2676       +6     
- Misses          81       82       +1     
+ Partials        73       72       -1
Impacted Files Coverage Δ
samtranslator/model/__init__.py 98.11% <100%> (+1.25%) ⬆️
samtranslator/model/sam_resources.py 95.48% <75%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3abea2...e2132f0. Read the comment docs.

@jlhood jlhood merged commit 30456c5 into aws:develop Mar 7, 2019
@keetonian keetonian deleted the event-type-error branch March 11, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants