feat: Add support for FindInMap in serverless app plugin #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix the Travis error |
brettstack
reviewed
Mar 15, 2019
brettstack
reviewed
Mar 19, 2019
| value = input_dict[self.intrinsic_name] | ||
|
|
||
| # FindInMap expects an array with 3 values | ||
| if not isinstance(value, list) or len(value) != 3: |
There was a problem hiding this comment.
Should we also throw errors in the other scenarios where we return input_dict? Or are there cases where we can't statically resolve them but they may get successfully resolved at runtime during CFN change set execution?
There was a problem hiding this comment.
You are right. In other scenarios, it is possible that some intrinsic functions are still left unresolved.
keetonian
reviewed
Mar 19, 2019
| Type: 'AWS::Serverless::Application' | ||
| Properties: | ||
| Location: | ||
| ApplicationId: !Ref ApplicationIdParam |
There was a problem hiding this comment.
Good, thank you for adding support for this.
keetonian
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Description of how you validated changes:
Added unit tests and end to end tests
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.