Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(policy-templates): add new policy for allowing step functions ex… #904

Merged
merged 9 commits into from
May 3, 2019

Conversation

ljacobsson
Copy link
Contributor

…ecutions

Description of changes:
Added policy template allowing states:StartExecution on a Step Functions state machine

Description of how you validated changes:
I have used the policy statement in my own stacks.

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ljacobsson ljacobsson closed this Apr 29, 2019
@ljacobsson ljacobsson reopened this Apr 30, 2019
@codecov-io
Copy link

codecov-io commented Apr 30, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@166304b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #904   +/-   ##
==========================================
  Coverage           ?   94.65%           
==========================================
  Files              ?       69           
  Lines              ?     3011           
  Branches           ?      559           
==========================================
  Hits               ?     2850           
  Misses             ?       85           
  Partials           ?       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 166304b...a6da17f. Read the comment docs.

@jlhood jlhood changed the base branch from master to develop May 2, 2019 17:52
Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this PR! This will definitely be a useful policy template to have. I've added a few comments. Also, I changed this PR to be based on the develop branch (latest code). Please rebase your branch to the latest develop so it can be merged.

Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding this policy. 😊

@keetonian keetonian merged commit a7035eb into aws:develop May 3, 2019
@ericallam
Copy link

I think it'd be nice to include the states:DescribeExecution action in this policy template. The use case being the lambda that starts an execution will receive an executionArn in the response and should be able to call describeExecution on that arn. The Resource could be structured using the State Machine name like so:

arn:${AWS::Partition}:states:${AWS::Region}:${AWS::AccountId}:execution:${StateMachineName}:*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants