-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fix for Internal transform failure on bad Condition syntax #908
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #908 +/- ##
===========================================
+ Coverage 94.65% 94.66% +<.01%
===========================================
Files 69 69
Lines 3011 3016 +5
Branches 559 561 +2
===========================================
+ Hits 2850 2855 +5
Misses 85 85
Partials 76 76
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciate you taking the time to fix this bug! We reviewed and have some minor comments, but in verifying our comments, we ended up making the changes ourselves so we'll go ahead and push those commits and get this merged in. Thanks again!
Thanks for the review & comments @jlhood and @keetonian |
tests/translator/input/error_function_with_invalid_condition_name.yaml
Outdated
Show resolved
Hide resolved
@jadhavmanoj no problem! Thank you for fixing this! |
Issue #892 :
Internal transform failure on bad Condition syntax:
Description of how you validated changes:
Checklist:
make pr
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.