Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal transform failure on path parameters #913

Merged
merged 29 commits into from
May 17, 2019

Conversation

jadhavmanoj
Copy link
Contributor

Issue #893 , if available:

Description of changes:
The issue occurs when the path contains path parameters which are defined at the path level.

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Manoj Jadhav and others added 29 commits April 28, 2019 18:40
@jadhavmanoj jadhavmanoj changed the title Develop Internal transform failure on path parameters May 9, 2019
@codecov-io
Copy link

Codecov Report

Merging #913 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #913      +/-   ##
===========================================
+ Coverage    94.66%   94.66%   +<.01%     
===========================================
  Files           69       69              
  Lines         3016     3018       +2     
  Branches       561      562       +1     
===========================================
+ Hits          2855     2857       +2     
  Misses          85       85              
  Partials        76       76
Impacted Files Coverage Δ
samtranslator/swagger/swagger.py 97.59% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71ab9b8...4678bf9. Read the comment docs.

Copy link
Contributor

@keetonian keetonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jadhavmanoj looks great! thank you for fixing this!

@praneetap praneetap merged commit 4d50d22 into aws:develop May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants