Updating README #950
Merged
Updating README #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #950 +/- ##
========================================
Coverage 94.86% 94.86%
========================================
Files 69 69
Lines 3055 3055
Branches 573 573
========================================
Hits 2898 2898
Misses 84 84
Partials 73 73Continue to review full report at Codecov.
|
| [](https://codecov.io/gh/awslabs/serverless-application-model) | ||
|
|
||
|  | ||
| <p align="center"> |
There was a problem hiding this comment.
This doesn't make sense.
brettstack
approved these changes
Jun 4, 2019
| [](https://codecov.io/gh/awslabs/serverless-application-model) | ||
|
|
||
|  | ||
| <p align="center"> |
There was a problem hiding this comment.
Empty tag? Some sort of hack?
keetonian
reviewed
Jun 6, 2019
README.md
Outdated
|
|
||
| This GitHub project is the starting point for AWS SAM. It contains the SAM specification, the code that translates SAM templates into AWS CloudFormation stacks, general information about the model, and examples of common applications. | ||
|  | ||
|  |
There was a problem hiding this comment.
Why is the SAM CLI release version here?
There was a problem hiding this comment.
I wanted to add badges for information that customers commonly interact with - it is usually the CLI version.
keetonian
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Updated README to better explain what SAM is, how to get started with SAM, provide quick links to documentation, and also help contributors get started.
For rendered content, see https://github.com/sanathkr/serverless-application-model/blob/readme_improvements/README.md
Description of how you validated changes:
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.