Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not log InvalidDocumentException as an uncaught error #973

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

keetonian
Copy link
Contributor

Issue #, if available:
N/A
Description of changes:
InvalidDocumentExceptions were being logged as uncaught exceptions. This removes this unnecessary logging.
Description of how you validated changes:
make pr ran and passed. Travis is running.
Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

Codecov Report

Merging #973 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #973   +/-   ##
=======================================
  Coverage     94.8%   94.8%           
=======================================
  Files           69      69           
  Lines         3079    3079           
  Branches       580     580           
=======================================
  Hits          2919    2919           
  Misses          84      84           
  Partials        76      76
Impacted Files Coverage Δ
samtranslator/plugins/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68d1ed7...ae9a5d2. Read the comment docs.

@praneetap praneetap merged commit a7291d4 into aws:develop Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants