-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: "Invalid permissions on Lambda function" on path parameter #992
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #992 +/- ##
==========================================
Coverage ? 94.81%
==========================================
Files ? 69
Lines ? 3240
Branches ? 631
==========================================
Hits ? 3072
Misses ? 87
Partials ? 81
Continue to review full report at Codecov.
|
@@ -492,7 +492,7 @@ def _get_permission(self, resources_to_link, stage, suffix): | |||
if not stage or not suffix: | |||
raise RuntimeError("Could not add permission to lambda function.") | |||
|
|||
path = path.replace('{proxy+}', '*') | |||
path = re.sub(r'{([a-zA-Z0-9._-]+|proxy\+)}', '*', path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution! This pr is against develop which is correct, could you please add tests as well? |
Thank you for your response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added tests.
5c4fc72
to
cba2be9
Compare
cba2be9
to
9e9a71a
Compare
rebased on current develop branch |
Thanks! Could you also add an input/output test? |
@brettstack Thanks. |
Issue #, if available:
#110
Description of changes:
fix the issue #110
Description of how you validated changes:
Deployed the following template successfully on CloudFormation.
Also I confirmed deployed APIs works well.
Checklist:
make pr
passesexamples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.