Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add API stage tags support (#384) #993

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Conversation

eduardovra
Copy link
Contributor

@eduardovra eduardovra commented Jun 22, 2019

Issue #, if available:
#384

Description of changes:
Add support to tags configuration on API stages.

Description of how you validated changes:
I confirmed that the transformed template is successfully deployed and the tags are created correctly.

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

PS. I wasn't sure if this feature required to be added in the examples referred by the checklist. Please let me know if this is necessary and I'll add this in the PR.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

Codecov Report

Merging #993 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #993      +/-   ##
===========================================
+ Coverage    94.71%   94.72%   +<.01%     
===========================================
  Files           69       69              
  Lines         3160     3164       +4     
  Branches       606      607       +1     
===========================================
+ Hits          2993     2997       +4     
  Misses          85       85              
  Partials        82       82
Impacted Files Coverage Δ
samtranslator/model/sam_resources.py 95.59% <ø> (ø) ⬆️
samtranslator/model/apigateway.py 97.72% <100%> (ø) ⬆️
samtranslator/model/api/api_generator.py 93.68% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88df20c...5530e70. Read the comment docs.

Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent PR! I see this is your first contribution to SAM. Thanks so much. We really appreciate the help!

@jlhood jlhood merged commit 275e461 into aws:develop Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants