Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding all the types so it's clearer to understand what types are sup… #996

Merged
merged 2 commits into from
Jul 16, 2019
Merged

Conversation

falnyr
Copy link
Contributor

@falnyr falnyr commented Jun 24, 2019

…ported

Issue #, if available:

Description of changes:

Description of how you validated changes:

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

Codecov Report

Merging #996 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #996   +/-   ##
=======================================
  Coverage   94.62%   94.62%           
=======================================
  Files          69       69           
  Lines        2997     2997           
  Branches      554      554           
=======================================
  Hits         2836     2836           
  Misses         85       85           
  Partials       76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6a3c51...fcd9759. Read the comment docs.

@jlhood jlhood changed the base branch from master to develop July 5, 2019 18:00
Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@jlhood
Copy link
Contributor

jlhood commented Jul 5, 2019

Also, could you rebase against the latest develop branch? You made your change against master, but new PRs get merged into develop. Thanks!

@brettstack brettstack merged commit d9b04f3 into aws:develop Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants