Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AwsProxyHttpServletRequest#getParameterValues does not support multiple query string #280

Closed
yeDor opened this issue Sep 20, 2019 · 3 comments
Assignees
Labels
Milestone

Comments

@yeDor
Copy link

yeDor commented Sep 20, 2019

  • Framework version: 1.3.2
  • Implementations: Spring Boot

Scenario

http request is <scheme>://<host>/<path>?state=xxx&state=yyy
Function in controller is func(@RequestParam(value = "state", required = false) List states)

Expected behavior

Param states contains {"xxx", "yyy"}

Actual behavior

Param states contains {"xxx"}

Proposed fix

In AwsProxyHttpServletRequest#getParameterValues instead of using AwsProxyHttpServletRequest#getFirstQueryParamValue
use AwsProxyHttpServletRequest#getParameterValues

Possible workaround

request in form <scheme>://<host>/<path>?state=xxx,yyy will work with spring

@yeDor yeDor closed this as completed Sep 20, 2019
@yeDor
Copy link
Author

yeDor commented Sep 20, 2019

was closed by a miss click

@yeDor yeDor reopened this Sep 20, 2019
@sapessi sapessi self-assigned this Sep 20, 2019
@sapessi sapessi added the bug label Sep 20, 2019
@sapessi sapessi added this to the Release 1.4 milestone Sep 20, 2019
@sapessi
Copy link
Collaborator

sapessi commented Sep 20, 2019

Thanks for the report @yeDor. I'm working on a fix and we'll push it out with the next release soon.

@sapessi
Copy link
Collaborator

sapessi commented Sep 30, 2019

Release 1.4 is out on maven central. The release notes include a list of all the changes. Closing this issue.

@sapessi sapessi closed this as completed Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants