Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-577 Ensure listeners are notified after dispatch #588

Merged
merged 2 commits into from
Jun 22, 2023
Merged

GH-577 Ensure listeners are notified after dispatch #588

merged 2 commits into from
Jun 22, 2023

Conversation

olegz
Copy link
Collaborator

@olegz olegz commented Jun 14, 2023 •
edited
Loading

Resolves #577

In AwsAsyncContext the listeners were notified too early effectively canceling the async context before the final dispatch.

This PR is rather trivial as it simply switches the order or operations.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@deki
Copy link
Collaborator

deki commented Jun 14, 2023

Looks good to me. Can we cover it in a unittest somehow?

@olegz
Copy link
Collaborator Author

olegz commented Jun 21, 2023

Let me see what I can do as the nature of it is a bit tricky

@olegz
Copy link
Collaborator Author

olegz commented Jun 22, 2023

@deki tests are pushed

@deki deki merged commit dcad0a2 into aws:main Jun 22, 2023
4 checks passed
@deki deki added this to the Release 2.0 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.0
Development

Successfully merging this pull request may close these issues.

HttpMessageNotReadableException occurs when handling a request.
2 participants
@olegz @deki