fix: Error with version 2.0.2 when multi-value header is active in alb #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deki
reviewed
Jun 19, 2024
|
|
||
| return request.getMultiValueHeaders().getFirst(HttpHeaders.HOST); | ||
| hostHeader = request.getMultiValueHeaders().getFirst(HttpHeaders.HOST); | ||
| return Arrays.asList(hostHeader.split(":")).get(0); |
There was a problem hiding this comment.
can you please remove the duplication, so we end up with a single return statement?
mbfreder
force-pushed
the
fix-alb-hostname
branch
from
0d7f617
to
9463113
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #909
Description of changes:
Fixes bug introduced by #827
When using Lambda as target in ALB, Customers can configure either multi-value or single value headers. host header information then comes in either a singleValueHeader object or a multivalueHeaders object.
This PR adds support for both object types.
By submitting this pull request