Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operation cloned Input/Output shapes can collide with types shape of same name #167

Closed
jasdel opened this issue Sep 3, 2020 · 0 comments · Fixed by #168
Closed

Operation cloned Input/Output shapes can collide with types shape of same name #167

jasdel opened this issue Sep 3, 2020 · 0 comments · Fixed by #168

Comments

@jasdel
Copy link
Contributor

jasdel commented Sep 3, 2020

The (de)serializer codegen looks like it can collide cloned operation input/output shapes with types of the same name used nested within the shape tree.

./test_submodules.sh service/glacier 'go test -run NONE'
Testing github.com/aws/aws-sdk-go-v2/service/glacier
# github.com/aws/aws-sdk-go-v2/service/glacier [github.com/aws/aws-sdk-go-v2/service/glacier.test]
./deserializers.go:1443:60: cannot use &output (type **DescribeVaultOutput) as type **types.DescribeVaultOutput in argument to awsRestjson1_deserializeDocumentDescribeVaultOutput
./deserializers.go:5354:6: awsRestjson1_deserializeDocumentDescribeVaultOutput redeclared in this block
	previous declaration at ./deserializers.go:1519:106
FAIL	github.com/aws/aws-sdk-go-v2/service/glacier [build failed]
jasdel added a commit to jasdel/smithy-go that referenced this issue Sep 3, 2020
Fixes aws#167 by ensuring operation input/output shape (de)serializers are
generated with unique name vs modeled shape (de)serializer functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant