Cast numbers in "uint oob" test error messages to avoid overflows #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For "uint oob" tests in TestAsInt32 and TestAsFloat64 in encoding/cbor/coerce_test.go, cast the number to Uint in the error message just as the number is cast in the test itself, so as to avoid overflows when tested on 32-bit architectures. Fixes "cannot use maxv + 1 (untyped int constant 2147483648) as int value in argument to fmt.Sprintf (overflows)" in TestAsInt32 and "cannot use maxv + 1 (untyped int constant 18014398509481985) as int value in argument to fmt.Sprintf (overflows)" in TestAsFloat64 Detected by Debian CI running on 386; see https://ci.debian.net/packages/g/golang-github-aws-smithy-go/testing/i386/47149094/#L1260
lucix-aws
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
For "uint oob" tests in TestAsInt32 and TestAsFloat64 in encoding/cbor/coerce_test.go, cast the number to Uint in the error message just as the number is cast in the test itself, so as to avoid overflows when tested on 32-bit architectures.
Fixes
cannot use maxv + 1 (untyped int constant 2147483648) as int value in argument to fmt.Sprintf (overflows)in TestAsInt32 andcannot use maxv + 1 (untyped int constant 18014398509481985) as int value in argument to fmt.Sprintf (overflows)in TestAsFloat64 on 32-bit platforms.Detected by Debian CI running on 386; see https://ci.debian.net/packages/g/golang-github-aws-smithy-go/testing/i386/47149094/#L1260
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.