Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying deploying worker nodes in private subnets #29

Merged
merged 2 commits into from
Jun 14, 2019

Conversation

jonjozwiak
Copy link

Clarifying deploying worker nodes in private subnets

Issue #, if available:
20

Description of changes:
Updated getting started guide, create cluster, and launch workers steps to clarify steps for private subnets. Ideally the getting started guide would also reference a CloudFormation template for a public/private VPC deployment.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@nrdlngr
Copy link
Contributor

nrdlngr commented Jun 14, 2019

Thanks for your contribution! Sorry for the delayed response. I had always planned on getting this in, and then I ended up rearranging a lot of the getting started content to incorporate the eksctl utility with our docs.

I realize that some of your PR was lost in my merge conflict resolution, but I don't want to make you rebase all of your work on the current doc source. Right now I am going to port the rest of your suggested changes into our docs in their current location.

I'm going to accept this PR as is for now and update in just a moment.

@nrdlngr nrdlngr merged commit 9e1f9bb into awsdocs:master Jun 14, 2019
nrdlngr added a commit that referenced this pull request Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants