Skip to content

Commit

Permalink
Multi: Fixes for comments and duplicate selection options for Aurora …
Browse files Browse the repository at this point in the history
…and Media Convert examples. (#6478)

* Fix duplicate version descriptions in aurora console app.

* Python: Fixes for duplicate names in aurora console choices.

* Fixes for mediaconvert snippet descriptions.
  • Loading branch information
rlhagerm committed May 22, 2024
1 parent 0b22105 commit e7a87c4
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions .doc_gen/metadata/mediaconvert_metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ mediaconvert_CreateJob:
github: dotnetv3/MediaConvert
sdkguide:
excerpts:
- description: Get the endpoint and set up the client.
- description: Set up the file locations, client, and wrapper.
snippet_tags:
- MediaConvert.dotnetv3.Setup
- description:
Expand Down Expand Up @@ -67,7 +67,7 @@ mediaconvert_ListJobs:
github: dotnetv3/MediaConvert
sdkguide:
excerpts:
- description: Get the endpoint and set up the client.
- description: Set up the file locations, client, and wrapper.
snippet_tags:
- MediaConvert.dotnetv3.Setup
- description: List the jobs with a particular status.
Expand Down Expand Up @@ -111,7 +111,7 @@ mediaconvert_GetJob:
github: dotnetv3/MediaConvert
sdkguide:
excerpts:
- description: Get the endpoint and set up the client.
- description: Set up the file locations, client, and wrapper.
snippet_tags:
- MediaConvert.dotnetv3.Setup
- description: Get a job by its ID.
Expand Down
2 changes: 1 addition & 1 deletion dotnetv3/Aurora/Scenarios/AuroraScenario.cs
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ public static async Task<DBEngineVersion> ChooseDBEngineVersionAsync(string dbPa
foreach (var version in allowedEngines)
{
Console.WriteLine(
$"\t{i}. Engine: {version.Engine} Version {version.EngineVersion}.");
$"\t{i}. {version.DBEngineVersionDescription}.");
i++;
}

Expand Down
8 changes: 4 additions & 4 deletions python/example_code/aurora/scenario_get_started_aurora.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ def create_cluster(self, cluster_name, db_engine, db_name, parameter_group):
engine_versions = self.aurora_wrapper.get_engine_versions(
db_engine, parameter_group["DBParameterGroupFamily"]
)
engine_choices = [ver["EngineVersion"] for ver in engine_versions]
engine_choices = [ver["EngineVersionDescription"] for ver in engine_versions]
print("The available engines for your parameter group are:")
engine_index = q.choose("Which engine do you want to use? ", engine_choices)
print(
Expand All @@ -142,7 +142,7 @@ def create_cluster(self, cluster_name, db_engine, db_name, parameter_group):
parameter_group["DBClusterParameterGroupName"],
db_name,
db_engine,
engine_choices[engine_index],
engine_versions[engine_index]["EngineVersion"],
admin_username,
admin_password,
)
Expand Down Expand Up @@ -173,15 +173,15 @@ def create_instance(self, cluster):
inst_opts = self.aurora_wrapper.get_orderable_instances(
cluster["Engine"], cluster["EngineVersion"]
)
inst_choices = list({opt["DBInstanceClass"] for opt in inst_opts})
inst_choices = list({opt["DBInstanceClass"] + ", storage type: " + opt["StorageType"] for opt in inst_opts})
inst_index = q.choose(
"Which DB instance class do you want to use? ", inst_choices
)
print(
f"Creating a database instance. This typically takes several minutes."
)
db_inst = self.aurora_wrapper.create_instance_in_cluster(
cluster_name, cluster_name, cluster["Engine"], inst_choices[inst_index]
cluster_name, cluster_name, cluster["Engine"], inst_opts[inst_index]["DBInstanceClass"]
)
while db_inst.get("DBInstanceStatus") != "available":
wait(30)
Expand Down

0 comments on commit e7a87c4

Please sign in to comment.