-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python - S3: Object lock workflow #6641
Conversation
f2bfd2b
to
75c7471
Compare
a52b66d
to
d009875
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow does not delete the buckets, which seems to be a requirement.
And it says cleanup is "successful" but also logs errors, which is confusing.
2024-07-12 09:52:12 [INFO] Cleanup completed successfully!
Summary of Cleanup Actions:
+------------------------------------------------+-----------+----------------------------------+---------------+---------+
| Bucket | Object | Version ID | Action | Status |
+------------------------------------------------+-----------+----------------------------------+---------------+---------+
| py-object-locking-no-lock-626 | file0.txt | null | Delete Object | Success |
| py-object-locking-no-lock-626 | file1.txt | null | Delete Object | Success |
| py-object-locking-no-lock-626 | - | - | Delete Bucket | Success |
| py-object-locking-lock-enabled-626 | file0.txt | VirfSajtC_cthWrAl9nTJaXWF00xV9oo | Delete Object | Success |
| py-object-locking-lock-enabled-626 | file1.txt | bpP1Kp_DcaduJ9U3DqMG3uujj_965Ubu | Delete Object | Success |
| py-object-locking-retention-after-creation-626 | file0.txt | x136CNeOY3leLClJVGK3DNJd_4lArOgh | Delete Object | Success |
| py-object-locking-retention-after-creation-626 | file1.txt | iKd2mkIiq1DyBtmylp1OAh1Vts46eiLZ | Delete Object | Success |
+------------------------------------------------+-----------+----------------------------------+---------------+---------+
Errors Encountered During Cleanup:
+------------------------------------------------+--------+------------+---------------+--------------------------------------------------------------------+
| Bucket | Object | Version ID | Action | Error |
+------------------------------------------------+--------+------------+---------------+--------------------------------------------------------------------+
| py-object-locking-lock-enabled-626 | - | - | Delete Bucket | Unable to disable object lock configuration after bucket creation. |
| py-object-locking-retention-after-creation-626 | - | - | Delete Bucket | Unable to disable object lock configuration after bucket creation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see tests for workflow.
6e81ae1
to
50f41c4
Compare
48cea36
to
1b5d93f
Compare
This pull request adds an example for a object locking workflow in Python.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.