Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heroku Exit #171

Open
3 of 8 tasks
awseward opened this issue Aug 27, 2022 · 1 comment
Open
3 of 8 tasks

Heroku Exit #171

awseward opened this issue Aug 27, 2022 · 1 comment

Comments

@awseward
Copy link
Owner

awseward commented Aug 27, 2022

Context

Steps

@awseward
Copy link
Owner Author

awseward commented Aug 28, 2022

Re: Set up a reverse proxy […]
  • It looks like the redirect isn't going to work out of the box for the ESP clients… If I'd need to reflash them to enable following redirects, that's no different from just flashing them with the new URL. 🙄 However, still probably worthwhile to turn on redirects for the next time something like this happens (we'll see if they follow 307/308 correctly or if they don't, like so many other HTTP client implementations I've come across… my guess is no 😔).

  • hurl isn't handling HTTP 308 correctly. It looks like that's a libcurl thing, not a hurl thing; can maybe work around this with a custom libcurl. At a cursory glance, looks like the fix is going to be here.

  • I haven't looked yet to see if if the HTTP client the launchd services are using will follow redirects. Would be sorta funny if none of the callers using the endpoint(s) will even be helped by setting up redirects in the first place. 🙃 It turns out this HTTP client also does not do the right thing with HTTP 308. 🙄 I guess that means that there's no real benefit to the proxy step outlined above.

    call_status_checker mishandling HTTP 308

    I'll probably just end up wrapping nim's std/httpclient.

    Fixed in https://github.com/awseward/call_status/releases/tag/0.6.5

awseward added a commit that referenced this issue Aug 28, 2022
Turns out they fixed 307/308 redirect handling! 🎉

See also: #171 (comment)
awseward added a commit that referenced this issue Aug 28, 2022
Turns out they fixed 307/308 redirect handling! 🎉

See also: #171 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant