Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid revision on heroku-built web binary #24

Closed
awseward opened this issue May 17, 2020 · 1 comment
Closed

Invalid revision on heroku-built web binary #24

awseward opened this issue May 17, 2020 · 1 comment
Assignees
@awseward

Comments

@awseward
Copy link
Owner

awseward commented May 17, 2020 •
edited
Loading

It seems like the heroku buildpack doesn't actually run inside a fit repo (probably just pulls a tarball and unpacks that), so revision is failing when web gets built there.

See:

2020-05-17T21:04:02.683861+00:00 heroku[web.1]: Restarting
2020-05-17T21:04:02.695903+00:00 heroku[web.1]: State changed from up to starting
2020-05-17T21:04:04.383037+00:00 app[web.1]: [DEBUG] version:  0.3.1
2020-05-17T21:04:04.383062+00:00 app[web.1]: [DEBUG] revision: fatal: not a git repository (or any parent up to mount point /)
2020-05-17T21:04:04.383063+00:00 app[web.1]: Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
2020-05-17T21:04:04.383919+00:00 app[web.1]: [INFO] Jester is making jokes at http://0.0.0.0:25635
2020-05-17T21:04:04.383919+00:00 app[web.1]: Starting 1 threads
2020-05-17T21:04:05.073666+00:00 heroku[web.1]: State changed from starting to up

☝️ To view this, tail logs and give it a heroku config:set LOG_LEVEL=DEBUG
@awseward awseward self-assigned this May 17, 2020
@awseward
Copy link
Owner Author

This might be the solution: https://devcenter.heroku.com/changelog-items/630

awseward added a commit that referenced this issue May 17, 2020
@awseward
Try reading revision from envvar first
299d198 
This is to address #24.

Luckily HEROKU provides `SOURCE_VERSION` that can we can just pull this
information from.

Also included in this change is a switch from `debug` to `info` for this
information.
awseward added a commit that referenced this issue May 17, 2020
@awseward
Try reading revision from envvar first
9e9ce12 
This is to address #24.

Luckily HEROKU provides `SOURCE_VERSION` that can we can just pull this
information from.

Also included in this change is a switch from `debug` to `info` for this
information.
@awseward awseward mentioned this issue May 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@awseward awseward

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@awseward